Int he old version it was was possible to define to which score a boundary belongs. In the new version it is fixed.

Replaced by 0144a3c98485.

Replaced by R20:67c376e3d67d

Hi Daniel,
I have not enough info to reproduce the error you reported to me but I guess it has to do with the empty constructors.
Could you check if this fixes your problem?

I noticed you used json.hpp from https://github.com/nlohmann/json directly in CCAM.
I think it is nicer to use the file from the other repo as submodule, which is fixed by this patch.
Do you have any concern?

Sorry for my late reply; I was on vacation last week.

I've just seen this commit was still not cleared from concern. The problematic file include/rosa/config/rosa_config.h was removed and the development branch has already been merged into master; so it is time to accept this commit.

MSVC gives the following error output:

In R20:43f9eab482727f3584abb669e33a29e01a5df9e4#9526, @dschnoell wrote:

I already changed it to shared pointers to hold the lib consistent. Or did I misunderstand something and abstractions are meant to be shared ?

So David you decide shared or unique pointers ? [Concerning the consistency]

In R20:43f9eab482727f3584abb669e33a29e01a5df9e4#9506, @dschnoell wrote:

I'm normally against using shared pointers when the resources aren't explicitly meant to be shared

In R20:43f9eab482727f3584abb669e33a29e01a5df9e4#9491, @btutzer wrote:

Any reason why you are opposed to use smart pointers? As they are used throughout the library, I would suggest to use them everywhere.
@juhasz what do you think?

Addressed in R20:c6b10668dfff

Addressed in R20:94a2eded6bee

Fixed in R20:de5b4d59be33.

Some suggestions about using unique_ptr...

I did a sloppy review before... I run doxygen now and found an undocumented parameter.

In R20:bd9ff3a209693e32c1772f8f340ea5d0fa06cfde#8953, @juhasz wrote:

I'll have a look in this problem...

I'll have a look in this problem...

In R20:ee76d676b758292b154392612da6c48d2347105a#8940, @goetzinger wrote:

you have half an hour in the next days for me?

In R20:fb3a26551f892bad0f33e42fbb10bec8a978fc88#8922, @btutzer wrote:

I still can't build though.

In R20:fb3a26551f892bad0f33e42fbb10bec8a978fc88#8834, @btutzer wrote:

'std::is_same_v' missing.

In R20:fb3a26551f892bad0f33e42fbb10bec8a978fc88#8834, @btutzer wrote:

Unfortunately, I had to wipe my computer clean as after updating libstdc++ from debian experimental to be able to build ROSA I was unable to boot.
I am now using clang-6 from the backports repo, which builds rosa fine, but breaks my build with this particular branch, due to 'std::is_same_v' missing.
I searched around and found no fix for that other than installing libstdc++ from testing, and I am not doing that again... Is there a way to work around std::is_same_v? If not, please tell me what distribution you are using so I can set up a virtual machine, but I would like to avoid that very much.

In R20:fb3a26551f892bad0f33e42fbb10bec8a978fc88#8688, @ewillegger wrote:

void DeluxeTuple<Ts...>::dump(std::ostream &OS, Seq<S0...>) const noexcept {

Will this also work if the type of S0 is already std::string??

In R20:fb3a26551f892bad0f33e42fbb10bec8a978fc88#8636, @btutzer wrote:

This commit introduces some doxygen warnings during the build:
[...]

I had a quick look, and it seems OK except for my inline comment about History::~History().

The problem reported in R20:a94537b537bb#8725 is fixed by R20:7eccb1408351.

@btutzer I can commit a fix if you agree with my suggested solution in R20:a94537b537bbdabf920b23f61c00f10e8b2d0388#8725. Let me know.

Having M_PI fixed as in my inline comment, MSVC complains about implicit conversions (line numbers in agent-functionalities.cpp are offset with 5 due to the fix for M_PI):

1>------ Build started: Project: agent-functionalities, Configuration: Debug x64 ------
1>agent-functionalities.cpp
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\utility(123): error C2220: warning treated as error - no 'object' file generated
1>C:\Users\juhas\Documents\GitHub\SoC_Rosa_repo\examples\agent-functionalities\agent-functionalities.cpp(121): note: see reference to function template instantiation 'std::pair<T,T>::pair<int,int,0>(_Other1 &&,_Other2 &&) noexcept' being compiled
1>        with
1>        [
1>            T=float,
1>            _Other1=int,
1>            _Other2=int
1>        ]
1>C:\Users\juhas\Documents\GitHub\SoC_Rosa_repo\examples\agent-functionalities\agent-functionalities.cpp(113): note: see reference to function template instantiation 'std::pair<T,T>::pair<int,int,0>(_Other1 &&,_Other2 &&) noexcept' being compiled
1>        with
1>        [
1>            T=float,
1>            _Other1=int,
1>            _Other2=int
1>        ]
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\utility(123): warning C4244: 'initializing': conversion from '_Ty' to '_Ty1', possible loss of data
1>        with
1>        [
1>            _Ty=int
1>        ]
1>        and
1>        [
1>            _Ty1=float
1>        ]
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\utility(123): warning C4244: 'initializing': conversion from '_Ty' to '_Ty2', possible loss of data
1>        with
1>        [
1>            _Ty=int
1>        ]
1>        and
1>        [
1>            _Ty2=float
1>        ]
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\memory(1547): warning C4244: 'argument': conversion from '_Ty' to 'D', possible loss of data
1>        with
1>        [
1>            _Ty=double
1>        ]
1>        and
1>        [
1>            D=float
1>        ]
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\memory(1601): note: see reference to function template instantiation 'std::_Ref_count_obj<_Ty>::_Ref_count_obj<double,double>(double &&,double &&)' being compiled
1>        with
1>        [
1>            _Ty=rosa::agent::LinearFunction<float,float>
1>        ]
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\memory(1602): note: see reference to function template instantiation 'std::_Ref_count_obj<_Ty>::_Ref_count_obj<double,double>(double &&,double &&)' being compiled
1>        with
1>        [
1>            _Ty=rosa::agent::LinearFunction<float,float>
1>        ]
1>C:\Users\juhas\Documents\GitHub\SoC_Rosa_repo\examples\agent-functionalities\agent-functionalities.cpp(116): note: see reference to function template instantiation 'std::shared_ptr<rosa::agent::LinearFunction<float,float>> std::make_shared<rosa::agent::LinearFunction<float,float>,double,double>(double &&,double &&)' being compiled
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\memory(1547): warning C4244: 'argument': conversion from '_Ty' to 'D', possible loss of data
1>        with
1>        [
1>            _Ty=int
1>        ]
1>        and
1>        [
1>            D=float
1>        ]
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\memory(1601): note: see reference to function template instantiation 'std::_Ref_count_obj<_Ty>::_Ref_count_obj<int,int>(int &&,int &&)' being compiled
1>        with
1>        [
1>            _Ty=rosa::agent::LinearFunction<float,float>
1>        ]
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\memory(1602): note: see reference to function template instantiation 'std::_Ref_count_obj<_Ty>::_Ref_count_obj<int,int>(int &&,int &&)' being compiled
1>        with
1>        [
1>            _Ty=rosa::agent::LinearFunction<float,float>
1>        ]
1>C:\Users\juhas\Documents\GitHub\SoC_Rosa_repo\examples\agent-functionalities\agent-functionalities.cpp(118): note: see reference to function template instantiation 'std::shared_ptr<rosa::agent::LinearFunction<float,float>> std::make_shared<rosa::agent::LinearFunction<float,float>,int,int>(int &&,int &&)' being compiled
1>Done building project "agent-functionalities.vcxproj" -- FAILED.
========== Build: 0 succeeded, 1 failed, 5 up-to-date, 0 skipped ==========

In R20:051baecaabd79d7aa95a6188cb449245c88eddf4#8713, @goetzinger wrote:

Seems fine for me. But I have two questions:

1. Can I also set the agent to decimation(X) instead of awaitAll?

Well done :)

In R20:cb3a24c0eeae370bda4839f7748c8ce7933576e9#8648, @btutzer wrote:

On another note: I tried to stick to your coding-style as much as possible. This included your naming convention of template typenames (T, A, ...). As RangeConfidence requires three such typenames, this get's a little out of hand. I'd rather call them DomainType (T), IdType (A) and RangeType (B), would you be ok with that @juhasz?

You added include/rosa/config/rosa_config.h in this commit. That file is generated from include/rosa/config/rosa_config.h.cmake by CMake and should not be here. Please remove it.

783f8c48d55e looks good!
Could you please complete the documentation comments for the new function before I accept this commit?

No, I wrote about line 58 of docs/Dev.srt, you changed line 43 in d46823eed74d; that line was fine. (Now I see though that line 43 has a grammar error: thrid-party)

In R20:3e6fe06d97aa877219c1be05f1e54d69b49f01d3#8555, @btutzer wrote:

Nitpick, but I do not like the doExecute function name. I would expect that such a function would really do something (have a side-effect). I think check or checkPending or something like that would me more appropriate.

Thanks for the fixes!

I add Maxi as auditor for this commit as he should comment about the interface if anything is wrong with it.

I add Maxi as auditor for this commit as he should comment about the interface if anything is wrong with it.

I do not remember exactly, unfortunately. But I think I could not compile using C++14 with MSVC. It could depend on compiler and/or library versions...

@btutzer, so far so good!

This is really minor, but I like to have comment and code (build script) to be consistent: please either mention RTTI in the comment or change the comment to a more general text like "removing restrictions for submodules" :)

@btutzer, why did you change the required C++ standard to C++14?

@goetzinger , please have a look in how the deluxe interface can be used for setting execution policies.

@btutzer, please have a look in this commit considering also commits 6f957842b101, 2e12d19af9ae, 4f138adb30fa that give clarification (sorry for having documentation scatter in other commits).

Storing the values as Abstractions would slice of any specialization,

Raw pointers are used in PartialFunction::RA, but RangeAbstraction destructs the stored values directly (i.e., the pointers only in this case). This causes memory leak.