HomePhorge
Diffusion SoC_Rosa_repo 94a2eded6bee

Changed CSVWriter class, so that all outputs should use some LOG functionality…
Audited94a2eded6bee
Actions

Referenced Files
None
Subscribers
• juhasz

Description

Changed CSVWriter class, so that all outputs should use some LOG functionality of the framework. Reason for this was concern 2f9441cbeaa6.

Details

Auditors
• juhasz
Provenance
• ewilleggerAuthored on Jun 10 2019, 3:56 PM
• ewilleggerPushed on Jun 10 2019, 3:56 PM
Parents
R20:cb724c38c6c3: Changed the example, that it also shows how the CSVIterator class works with…
Branches
Unknown
Tags
Unknown

Event Timeline

• ewillegger committed R20:94a2eded6bee: Changed CSVWriter class, so that all outputs should use some LOG functionality… (authored by • ewillegger).Jun 10 2019, 3:56 PM
• juhasz mentioned this in R20:2f9441cbeaa6: Added CSVTupleWriter class, which writes std::tuples in a recursion fashion in….Jun 11 2019, 9:23 AM
• juhasz raised a concern with this commit.Jun 11 2019, 9:25 AM
• juhasz subscribed.
• juhasz added inline comments.
/include/rosa/support/csv/CSVWriter.hpp
28

#include "rosa/support/log.h" would be safer as in moving the file to another directory would not break the file.

This commit now has outstanding concerns.Jun 11 2019, 9:25 AM
• juhasz accepted this commit.Jun 11 2019, 4:13 PM

Addressed in R20:c6b10668dfff

All concerns with this commit have now been addressed.Jun 11 2019, 4:13 PM

Changes (1)

PathSize
include/
rosa/
support/
csv/

R20:94a2eded6bee

View Options

include/rosa/support/csv/CSVWriter.hpp

Loading...