Automatically init submodule cxxopts on build
Description
Description
Details
Details
- Auditors
• juhasz - Provenance
• btutzer Authored on Apr 30 2019, 4:39 PM • btutzer Pushed on Apr 30 2019, 4:39 PM - Parents
- R20:bf31117598bd: Also allow dinamic casts and typeid for modules (as cxxopts uses them)
- Branches
- Unknown
- Tags
- Tasks
- Restricted Maniphest Task
Event Timeline
Comment Actions
Please have a look at the whole branch. More or less it's just copied and pasted from T108#1906 though.
I added some lines in modules/CMakeLists.txt to make sure the submodule is initialized before the build. If not, not even cmake itself would successfully configure since there is no CMakeLists.txt in modules/cxxopts/ before submodule initialization.
If you approve, I will merge this into master.
Comment Actions
@btutzer, so far so good!
See comments I wrote for other commits in the branch.
Since this directory is supposed to include submodules (potentially several in the future), would it be possible to run the git command for all subdirectories with a foreach()?
It would be also nice to have a mention of the new directory, modules, in docs/Dev.srt; particularly in sections The Source Directory and Software Sources/Logical Structure (just a one-liner like for apps).