Added the possiblity to write a header line into the file, but currently the…
Auditedf16511b1a0bd
Actions

Referenced Files

None

Subscribers

Description

Added the possiblity to write a header line into the file, but currently the size of the header line and the other data is not checked. This has to be improved.

Details

Auditors

• juhasz

Provenance

• ewillegger	Authored on Jun 2 2019, 4:02 PM
• ewillegger	Pushed on Jun 2 2019, 4:03 PM

Parents

R20:5f3e654f6831: Merge branch 'CSVFiles' of ssh://phabricator.ict.tuwien.ac.

Branches

Unknown

Tags

Unknown

Event Timeline

• ewillegger committed R20:f16511b1a0bd: Added the possiblity to write a header line into the file, but currently the… (authored by • ewillegger).Jun 2 2019, 4:02 PM

• juhasz raised a concern with this commit.Jun 10 2019, 12:32 PM

• juhasz subscribed.

• juhasz added inline comments.

/include/rosa/support/csv/CSVWriter.hpp
152	This is a minor thing but it would look better (and potentially result in more efficient code if the tuple is big) to take `V` by-reference (`&`) rather than by-value. This also applies to CSVTupleWriter::write() and writeHeader(), which could take a constant reference instead of a copy.