HomePhorge

Implement DeluxeExecutionPolicy Ref T136

Description

Implement DeluxeExecutionPolicy Ref T136

Add DeluxeExecutionPolicy interface and implementations Decimation, AwaitAll, and AwaitAny. Adjust DeluxeAgent and DeluxeSensor to use DeluxeExecutionPolicy. Define corresponding get/set functions in DeluxeContext.

Details

Auditors
btutzer
Provenance
Dávid JuhászAuthored on Apr 18 2019, 11:21 PM
juhaszPushed on Apr 18 2019, 11:21 PM
Parents
R20:2b098d7d35af: Create .gitignore
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task

Event Timeline

Dávid Juhász <juhasz.david.scholar@gmail.com> committed R20:3e6fe06d97aa: Implement DeluxeExecutionPolicy Ref T136 (authored by Dávid Juhász <juhasz.david.scholar@gmail.com>).Apr 18 2019, 11:21 PM
Diffusion added a task: Restricted Maniphest Task.

@btutzer, please have a look in this commit considering also commits 6f957842b101, 2e12d19af9ae, 4f138adb30fa that give clarification (sorry for having documentation scatter in other commits).

Nitpick, but I do not like the doExecute function name. I would expect that such a function would really do something (have a side-effect). I think check or checkPending or something like that would me more appropriate.

Nitpick, but I do not like the doExecute function name. I would expect that such a function would really do something (have a side-effect). I think check or checkPending or something like that would me more appropriate.

I concur, doExecute hints that something would actually happen. Nevertheless, check does not sound right to me either. I would expect that a function called checkPending takes care of any pending stuff...

What do you think about shouldProcess? I find it a good descriptive function name: it tells whether processing should be done with respect to the parameters.

What do you think about shouldProcess? I find it a good descriptive function name: it tells whether processing should be done with respect to the parameters.

shouldProcess sounds good! Thanks!

All concerns with this commit have now been addressed.May 3 2019, 11:16 AM