Added possilbe delimeters set by user for CSVReader
Description
Description
Details
Details
- Auditors
• juhasz - Provenance
• ewillegger Authored on May 1 2019, 10:58 AM • ewillegger Pushed on May 1 2019, 10:58 AM - Parents
- R20:39e962604457: Initial commit for CSVFile feature branch.
- Branches
- Unknown
- Tags
Event Timeline
Comment Actions
You added include/rosa/config/rosa_config.h in this commit. That file is generated from include/rosa/config/rosa_config.h.cmake by CMake and should not be here. Please remove it.
| /include/rosa/support/csv/CSVReader.hpp | ||
|---|---|---|
| 253 | It would be a better practice to initialize all the member field by the initializer list of the constructor. | |
Comment Actions
Resolved issues of code review.
| /include/rosa/support/csv/CSVReader.hpp | ||
|---|---|---|
| 253 | Resolved with commit R20:c44cf3301926 | |
Comment Actions
I've just seen this commit was still not cleared from concern. The problematic file include/rosa/config/rosa_config.h was removed and the development branch has already been merged into master; so it is time to accept this commit.