HomePhorge

Add submodule json
Partially Audited5fd638f5aeaa

Description

Add submodule json

Add submodule JSON with version v3.6.1 and tests disabled.
Remove the corresponding json.hpp file from the CCAM app, and
use the header from the submodule instead.

Details

Auditors
goetzinger
btutzer
Provenance
Dávid JuhászAuthored on Apr 17 2020, 6:04 PM
juhaszPushed on Apr 17 2020, 6:39 PM
Parents
R20:67f904b676ba: Fix usage of submodule cxxopts
Branches
Unknown
Tags
Unknown

Event Timeline

Dávid Juhász <juhasz.david.scholar@gmail.com> committed R20:5fd638f5aeaa: Add submodule json (authored by Dávid Juhász <juhasz.david.scholar@gmail.com>).Apr 17 2020, 6:33 PM
juhasz subscribed.

I noticed you used json.hpp from https://github.com/nlohmann/json directly in CCAM.
I think it is nicer to use the file from the other repo as submodule, which is fixed by this patch.
Do you have any concern?

btutzer added subscribers: goetzinger, btutzer.

LGTM.

@goetzinger to use the new code, call the following command:

git pull
git submodule update --init --recursive

A simple git-pull does not fetch new submodules.