HomePhorge
Diffusion SoC_Rosa_repo bb607dfb87d8

added a semi implementation
Auditedbb607dfb87d8
Actions

This commit no longer exists in the repository. It may have been part of a branch which was deleted.

Description

added a semi implementation

the full implementation is dependent on another task therefor it needs to be implemented while merging

the file should be compileable and testable, a test-file is provided at the end of the file.

Details

Auditors
• btutzer
dschnoell
Provenance
danielAuthored on Apr 26 2019, 12:19 PM
dschnoellPushed on Apr 26 2019, 12:21 PM

Event Timeline

daniel <daniel.s13@live.de> committed R20:bb607dfb87d8: added a semi implementation (authored by daniel <daniel.s13@live.de>).Apr 26 2019, 12:20 PM
• btutzer raised a concern with this commit.Apr 30 2019, 3:19 PM
• btutzer subscribed.

Hi,
I saw that you are doing many sanity checks on the template types inside methods, like

static_assert(std::is_arithmetic<Type>::value); // sanitny check

I think it would be better to do this once per template instead to improve readability.

This commit now has outstanding concerns.Apr 30 2019, 3:19 PM
dschnoell accepted this commit.May 31 2019, 10:52 AM
dschnoell subscribed.

I changed this inside the functionality_Reliability branch

• btutzer added a comment.Jun 26 2019, 1:31 PM
In R20:bb607dfb87d8a548844c3241ed5d148db7243be5#9036, @dschnoell wrote:

I changed this inside the functionality_Reliability branch

Hi,
sorry I never got back to you on that.
I do not see any fix in the Functionality_Reliability branch though. There are still lots of static_asserts inside functions when they could be done once per template.

dschnoell added a comment.Jun 27 2019, 9:14 AM

The only static asserts in RelibilityConfidenceCombinator.h are at lines 193 195 197 and in CrossCombinator.h at lines 80 82 besides them I can't find any.

• btutzer accepted this commit.Jun 27 2019, 12:12 PM
In R20:bb607dfb87d8a548844c3241ed5d148db7243be5#9498, @dschnoell wrote:

The only static asserts in RelibilityConfidenceCombinator.h are at lines 193 195 197 and in CrossCombinator.h at lines 80 82 besides them I can't find any.

As discussed, I looked at the wrong commit.
All my points were addressed in b844a8fa9d69.

All concerns with this commit have now been addressed.Jun 27 2019, 12:12 PM

Commit No Longer Exists

This commit no longer exists in the repository.