Diffusion SoC_Rosa_repo 8ca962de18a6

insert data into state (not finished yet
8ca962de18a6
Actions

Referenced Files

None

Subscribers

• btutzer

Description

insert data into state (not finished yet

Details

Provenance

Maximilian Goetzinger	Authored on May 16 2019, 12:28 PM
goetzinger	Pushed on May 16 2019, 12:28 PM

Parents

R20:2868d094d859: just a bit

Branches

Unknown

Tags

Unknown

Event Timeline

Maximilian Goetzinger <maxgot@utu.fi> committed R20:8ca962de18a6: insert data into state (not finished yet (authored by Maximilian Goetzinger <maxgot@utu.fi>).May 16 2019, 12:28 PM

I guess you are planning to implement the match() and noMatch() fuzzy functions in this class, right? So in the State detector you would call them for each known state and then when StateDetector gets a new Sample you would push the new sample to the State that it matches best to, or creating a new State if no State fits?

/include/rosa/agent/State.hpp
28	As I explained in my e-mail response, I don't think we need an output here. In my understanding, a State should just contain what's needed to store the samples (Histories) and the capability to compute whether a state belongs to it or not. Return value of the belongs-to-state checks will always be a confidence, so a float (or a double), no need for a template type IMHO.
35	Please avoid raw-pointers You need to specify the Types that the PartialFunction is using here. You already know that your samples will have type DIN and since you are calculating a confidence using this partial-function, it's output type should be float (or double). shared_ptr<PartialFunction<DIN, float>> ConfidenceSimilarToSample;
60	On it!
75	Use DAB.full() here.
84	As you never use the policy HistoryPolicy::SRWF, this will never be false. Place an assert here to make sure of it.