(i) changed driftFuzzyFunction (stabel, down, up), (ii) changed DABHistorySize…
13da2946880e
Actions

Referenced Files

None

Subscribers

Description

(i) changed driftFuzzyFunction (stabel, down, up), (ii) changed DABHistorySize to DriftLookBackRange, and (iii) decision process of SignalStateCondition takes history decisions into account

Details

Provenance

Maximilian Goetzinger	Authored on Jan 23 2021, 10:56 PM
goetzinger	Pushed on Jan 23 2021, 10:57 PM

Parents

R20:fe260c66ea5c: fixed error with average of drift calculation

Branches

Unknown

Tags

Unknown

Event Timeline

Maximilian Goetzinger <maxgot@utu.fi> committed R20:13da2946880e: (i) changed driftFuzzyFunction (stabel, down, up), (ii) changed DABHistorySize… (authored by Maximilian Goetzinger <maxgot@utu.fi>).Jan 23 2021, 10:56 PM

• btutzer subscribed.Jan 24 2021, 10:37 AM

• btutzer added inline comments.

/apps/ccam/ccam.cpp
325	We have lot's of constant linear functions, maybe it would be better to create a 'Constant' abstraction, as that would not be much work but would increase readability by a lot. Alternatively / additionally we could have both left- and right- limits with default values in the PartialFunction abstraction.
/include/rosa/agent/SignalState.hpp
213	PROCDATATYPE should be used here instead of INDATATYPE This works for our current usecases, but if we look at integers for example this would result in cut-off decimal digits.
567–568	CurrentDab ist schon in der History
628	Der current DAB ist hier doch auch schon in der history, oder? Brauchst hier nicht ein -1? @567
643–653	Ich bin skeptisch ob das gute Ergebnisse bringt. Die history hat einfach ein riesieges Gewicht. Vielleicht sollten wir hier doch wieder die weiter zurückliegenden weniger gewichten (nicht nur avg) oder irrgendwie noch die distanz als Gewicht verwenden?